Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add IPv6 to block unencrypted connections whitelist - #13515

Closed
ghost wants to merge 4 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 4 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 7, 2017

Copy link
Copy Markdown

@J0WI

J0WI commented Nov 26, 2017

Copy link
Copy Markdown
Contributor

Sadly the repo is gone and needs to be rebased, but lthe missing IPv6 link local address is still an issue.
Let's ask @Hainish if he has any use for this patch.

@Hainish

Hainish commented Dec 4, 2017

Copy link
Copy Markdown
Member

The removal of regex is preferred, so I'm inclined to keep these changes.

I find the regex change for hostnames starting with 127. overly hard to read for no added benefit (other than it being stricter regex, but I don't really see an instance where that would be helpful.) I'll keep the existing regex in place.

The IPv6 conditional looks good.

@Hainish

Hainish commented Dec 4, 2017

Copy link
Copy Markdown
Member

Fixed in 5db3993

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants